[overtime] Overtime strategy#1762
Conversation
Co-authored-by: Chaitanya <yourchaitu@gmail.com>
src/strategies/overtime/index.ts
Outdated
|
|
||
| export const author = 'thales-markets'; | ||
| export const version = '1.0.0'; | ||
| export const dependOnOtherAddress = true; |
There was a problem hiding this comment.
Hi @vladanthales We are not accepting new strategies that override due to scaling issue, Instead you can use api-v2-override strategy in your space to call the API instead, let me know if you have any questions
There was a problem hiding this comment.
I have checked api-v2-override, but I don't see how I can use that here (that strategy uses API to get scores for addresses). In my strategy, my API returns EOA/smartAccount map (since the voter can't vote with a smart account, I want to assign that score to EOA). So, score is still based on balance-of strategy, just I need map from API.
There was a problem hiding this comment.
We have an old thales strategy, can I update that strategy with this code and use that one (since it's old strategy)?
There was a problem hiding this comment.
hmm thales strategy is not a override strategy 🙈 overriding is important for you? or you added export const dependOnOtherAddress = true; by mistake?
There was a problem hiding this comment.
Okay, I double-checked and removed that part. No need to override smartAccount voting power, since user can't vote with smartAccount. Code updated.
Changes proposed in this pull request: